wip: address feedback

Author: tivac

src/rules/prefer-reactive-destructuring.ts

@@ -40,23 +40,27 @@ export default createRule("prefer-reactive-destructuring", {
           node,
           loc: node.loc,
           messageId: "useDestructuring",
-          suggest: [
-            {
-              messageId: "suggestDestructuring",
-              fix: (fixer) => [
-                fixer.insertTextBefore(
-                  lToken,
-                  matched ? `({ ` : `({ ${prop}: `,
-                ),
-                fixer.insertTextAfter(lToken, ` }`),
-                fixer.replaceTextRange(
-                  [rTokens[0].range[0], rTokens[1].range[1]],
-                  "",
-                ),
-                fixer.insertTextAfter(rTokens[1], ")"),
-              ],
-            },
-          ],
+          suggest:
+            // Don't show suggestions for entries like $: info = foo.bar.info, the destructuring
+            // just looks too gross and complicates the rule too much
+            right.object.type === "MemberExpression"
+              ? []
+              : [
+                  {
+                    messageId: "suggestDestructuring",
+                    fix: (fixer) => [
+                      fixer.insertTextBefore(
+                        lToken,
+                        matched ? `({ ` : `({ ${prop}: `,
+                      ),
+                      fixer.insertTextAfter(lToken, ` }`),
+                      fixer.replaceTextRange(
+                        [rTokens[0].range[0], rTokens[1].range[1]],
+                        ")",
+                      ),
+                    ],
+                  },
+                ],
         })
       },
     }

tests/fixtures/rules/prefer-reactive-destructuring/invalid/test01-errors.json

@@ -7,7 +7,7 @@
       {
         "desc": "Use destructuring to get finer-grained redraws",
         "messageId": "suggestDestructuring",
-        "output": "<!-- prettier-ignore -->\n<script>\n    $: ({ info } = foo)\n    $: bar = foo.something\n</script>\n"
+        "output": "<!-- prettier-ignore -->\n<script>\n    $: ({ info } = foo)\n    $: bar = foo.something\n    $: baz = foo.bar.baz\n</script>\n"
       }
     ]
   },
@@ -19,8 +19,14 @@
       {
         "desc": "Use destructuring to get finer-grained redraws",
         "messageId": "suggestDestructuring",
-        "output": "<!-- prettier-ignore -->\n<script>\n    $: info = foo.info\n    $: ({ something: bar } = foo)\n</script>\n"
+        "output": "<!-- prettier-ignore -->\n<script>\n    $: info = foo.info\n    $: ({ something: bar } = foo)\n    $: baz = foo.bar.baz\n</script>\n"
       }
     ]
+  },
+  {
+    "message": "Prefer destructuring in reactive statements",
+    "line": 5,
+    "column": 8,
+    "suggestions": null
   }
 ]

tests/fixtures/rules/prefer-reactive-destructuring/invalid/test01-input.svelte

@@ -2,4 +2,5 @@
 <script>
     $: info = foo.info
     $: bar = foo.something
+    $: baz = foo.bar.baz
 </script>