-
Notifications
You must be signed in to change notification settings - Fork 61
Conversation
@KubaJastrz Really appreciate your work. I almost want to merge it directly except for a few questions.
Can you elaborate what breaking changes are?
Do you mean those plugins have been added by default? And what's your reason about adding
Would you mind explaining your plan a little more? Just want to confirm in advance and to avoid changes in vain. |
It seems like stylelint/stylelint#4254 prevents us from passing fixture file paths directly into - fixture = path.join(__dirname, './fixtures/...')
+ fixture = slash(path.join(__dirname, './fixtures/...')) Instead of it('should use the right file', () => {
expect(data.results[0].source).toEqual(fixture)
})
Yes, for example @babel/parser supports I didn't add
I would like to look at #231, but I wanted to make sure that we are using latest @babel/core first, which added support for new configuration files that could come in handy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for @KubaJastrz's detailed explanations. You can go ahead for #231. Before merging, I will wait for days to listen advices from @emilgoldsmith and @mxstbr.
Changes:
dependencies
anddevDependencies
jest
,eslint
,prettier
,husky
andlint-staged
slash
to fix tests failing on Windows after stylelint@13 breaking changes@babel/parser
config that are already supported (in latest 7.8.3 version)This has been done in preparations for #231