Skip to content
This repository was archived by the owner on May 14, 2021. It is now read-only.

Fixed: set errored to false if warning no contains errors. #23

Merged
2 commits merged into from
Jun 4, 2017

Conversation

alexander-akait
Copy link
Contributor

@alexander-akait alexander-akait commented Apr 15, 2017

Closes #22

BTW, i would recommend don't changed stylelintResult, just add node in README.md about disable no-empty-source and no-missing-end-of-source-newline, in next version we can change stylelintResult (example rename warnings to another name) and stylelint-processor-styled-components will cease to work as expected.

Copy link
Member

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mxstbr
Copy link
Member

mxstbr commented May 22, 2017

in next version we can change stylelintResult (example rename warnings to another name) and stylelint-processor-styled-components will cease to work as expected.

That would be a major version release anyway, in which case we'd have to update and release a major version too. Might as well make that explicit rather than only mentioning it in the docs and avoid a footgun for people?

@mxstbr
Copy link
Member

mxstbr commented May 22, 2017

Can you fix the linting errors?

   98:1  error  Trailing spaces not allowed                                     no-trailing-spaces
  100:7  error  Assignment to property of function parameter 'stylelintResult'  no-param-reassign

@ghost
Copy link

ghost commented Jun 1, 2017

BTW, i would recommend don't changed stylelintResult

@evilebottnawi Next to this pr as a patch, I think it would be a good solution to define the rules that need to be disabled in a shareable config. Users can then extend that config and list it before all others so it overrides all other rules (https://stylelint.io/user-guide/configuration/#extends).

Say for example: stylelint-config-styled-components

Then we could leave stylelintResult as is. I think defining the shareable config as a peerDependency could be a good way to allow coupling a version of this lib to a version of the config. What do you think?

Also, would you mind fixing the linting errors? If you don't have time let me know. If you could then allow me access to the pr I'd be happy to help.

@alexander-akait
Copy link
Contributor Author

@ismay sorry, no time now for this, maybe late 😞

@ghost
Copy link

ghost commented Jun 1, 2017

sorry, no time now for this, maybe late

No worries, linting errors are fixed 👍 Just ignored the no-param-reassign error btw, since I think the current style makes it clear what's going on. Also, we should be removing it later anyway, with the shareable config.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 99.225% when pulling 173ee90 on evilebottnawi:patch-1 into 9842e3e on styled-components:master.

@ghost
Copy link

ghost commented Jun 2, 2017

I'll try and rebase it this weekend btw, so we can get this merged.

evilebottnawi and others added 2 commits June 4, 2017 16:21
styled-components#22

BTW, i would recommend don't changed `stylelintResult`, just add node in `README.md` about disable `no-empty-source` and `no-missing-end-of-source-newline`, in next version we can change `stylelintResult` (example rename `warnings` to another name) and `stylelint-processor-styled-components` will cease to work as expected.
@ghost ghost force-pushed the patch-1 branch from 173ee90 to 86fe76a Compare June 4, 2017 14:22
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.225% when pulling 86fe76a on evilebottnawi:patch-1 into 68b4c4f on styled-components:master.

@ghost ghost merged commit c8414b7 into styled-components:master Jun 4, 2017
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants