-
Notifications
You must be signed in to change notification settings - Fork 61
Fixed: set errored
to false
if warning
no contains errors.
#23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
That would be a major version release anyway, in which case we'd have to update and release a major version too. Might as well make that explicit rather than only mentioning it in the docs and avoid a footgun for people? |
Can you fix the linting errors?
|
@evilebottnawi Next to this pr as a patch, I think it would be a good solution to define the rules that need to be disabled in a shareable config. Users can then extend that config and list it before all others so it overrides all other rules (https://stylelint.io/user-guide/configuration/#extends). Say for example: Then we could leave Also, would you mind fixing the linting errors? If you don't have time let me know. If you could then allow me access to the pr I'd be happy to help. |
@ismay sorry, no time now for this, maybe late 😞 |
No worries, linting errors are fixed 👍 Just ignored the no-param-reassign error btw, since I think the current style makes it clear what's going on. Also, we should be removing it later anyway, with the shareable config. |
I'll try and rebase it this weekend btw, so we can get this merged. |
styled-components#22 BTW, i would recommend don't changed `stylelintResult`, just add node in `README.md` about disable `no-empty-source` and `no-missing-end-of-source-newline`, in next version we can change `stylelintResult` (example rename `warnings` to another name) and `stylelint-processor-styled-components` will cease to work as expected.
Closes #22
BTW, i would recommend don't changed
stylelintResult
, just add node inREADME.md
about disableno-empty-source
andno-missing-end-of-source-newline
, in next version we can changestylelintResult
(example renamewarnings
to another name) andstylelint-processor-styled-components
will cease to work as expected.