Skip to content
This repository was archived by the owner on May 14, 2021. It is now read-only.

v1.0.0 #126

Merged
merged 3 commits into from
Sep 19, 2017
Merged

v1.0.0 #126

merged 3 commits into from
Sep 19, 2017

Conversation

mxstbr
Copy link
Member

@mxstbr mxstbr commented Sep 19, 2017 •
edited
Loading

  • Update CHANGELOG
  • Deploy version of website with moduleName
  • Publish v1.0.0
  • Publish blogpost

@mxstbr mxstbr requested review from a user and emilgoldsmith September 19, 2017 13:57
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cf8da58 on v1 into aac20ac on master.

ghost
ghost reviewed Sep 19, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my other comment about the shareable config I'm not missing anything in the changelog 👍

CHANGELOG.md Outdated
@@ -1,3 +1,9 @@
### 1.0.0
* added shared stylelint config to configure a couple of rules to fit with styled-components’ style of writing CSS
Copy link

@ghost ghost Sep 19, 2017 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this initially added in cf988ad, which was released with 0.4.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, moved it!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 95a4e93 on v1 into aac20ac on master.

emilgoldsmith
emilgoldsmith approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@emilgoldsmith emilgoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, as far as I can see we added all the rest before this release, right? Let's publish! :D

@mxstbr
Copy link
Member Author

mxstbr commented Sep 19, 2017

Published! Now just gotta do all that other jazz...

@mxstbr mxstbr merged commit 966d6ce into master Sep 19, 2017
@mxstbr mxstbr deleted the v1 branch September 19, 2017 19:35
@mxstbr
Copy link
Member Author

mxstbr commented Sep 19, 2017

It's oooouuuutttt!!

https://medium.com/styled-components/announcing-production-ready-linting-for-styled-components-58adcdc4a97
https://spectrum.chat/thread/0b38ed2c-82e0-468b-bbc2-4b2ba5752f39

@ghost
Copy link

ghost commented Sep 20, 2017

Woohoo! Great! 😃 🎉 🎈🎉 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emilgoldsmith emilgoldsmith emilgoldsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxstbr @coveralls @emilgoldsmith