Move typescript to devDependencies

[emilgoldsmith]

I found a solution :). As long as you guys are okay with conditional requires. This resolves #99

[ghost]

Ah nice. And the typescript peerDependency requirement from typescript-eslint-parser still gets logged when installing this processor right? Because that also makes it clear to the end-user that we require a specific version of typescript, should they want to use it.

[coveralls]

Coverage remained the same at 100.0% when pulling a592210 on packages/move-typescript-dev-depencies into fbf7805 on master.

[emilgoldsmith]

Ah nice. And the typescript peerDependency requirement from typescript-eslint-parser still gets logged when installing this processor right?

I tried uninstalling typescript completely (just for tests) and ran the non-typescript tests and it didn't work without the dynamic require, did with it, and typescript tests work with dynamic require as well when typescript is then installed of course :). It still logs the annoying "you are not using the intended version" thing when you use it, I'm not sure about on install though. I can see that in a package.json since they actually only put any version of Typescript as their peerDependency. So they enforce the version only in those annoying logs.

[ghost]

I can see that in a package.json since they actually only put any version of Typescript as their peerDependency. So they enforce the version only in those annoying logs.

Hmm, yeah I guess that is so they can leave the final decision to the user, if they want to try a different version it might still work.

[emilgoldsmith]

Hmm, yeah I guess that is so they can leave the final decision to the user, if they want to try a different version it might still work.

Yeah, I'm not quite sure what current behaviour would be during installation to be honest, I just tried doing an install now of the package now that didn't give any warning... so I'm not quite sure. But given the behaviour during the tests with the warning logs coming up about recommended version I'm pretty sure that should happen when you use our package as well.

I think I'm personally okay with this to the extent that I'd merge this in and think it shouldn't cause any problems. If it does I guess we'd hopefully get some issues submitted so we could become aware of it, but I think this should be okay.

[ghost]

I think I'm personally okay with this to the extent that I'd merge this in and think it shouldn't cause any problems. If it does I guess we'd hopefully get some issues submitted so we could become aware of it, but I think this should be okay.

Yeah I agree 👍

[emilgoldsmith]

Okay, let's merge it in then, this is pretty minor, mostly for our own preferences so I'll just put it in master and it can go with some future publish, maybe even 1.0 if we don't publish anything else before then.