Skip to content
This repository was archived by the owner on Mar 7, 2019. It is now read-only.

fix: distinguish between module and script only for node environment #38

Merged
merged 1 commit into from
Jul 18, 2018
Merged

fix: distinguish between module and script only for node environment #38

merged 1 commit into from
Jul 18, 2018

Conversation

petrhanak
Copy link
Contributor

@petrhanak petrhanak commented Jul 18, 2018 •
edited
Loading

React environment has everything in ES6 regardless of extension, d4aaf38 makes sense only for node.

@petrhanak petrhanak requested a review from robertrossmann July 18, 2018 09:47
robertrossmann
robertrossmann approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@robertrossmann robertrossmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, true, that mjs thing is a node convention... Thanks!

@robertrossmann robertrossmann merged commit 83365bc into master Jul 18, 2018
@robertrossmann robertrossmann deleted the script-module-node-only branch July 18, 2018 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robertrossmann robertrossmann robertrossmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrhanak @robertrossmann