Skip to content

convert relative refs when resolving an external schema #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 29, 2023

Conversation

brendarearden
Copy link

@brendarearden brendarearden commented Sep 26, 2023

Motivation and Context

stoplightio/prism#2385
This also seems to be related APIDevTools#200

Getting error MissingPointerError when $ref has a sibling of any type.

Description

Pulled the changes from: karlvr@6d2740b
Additionally I removed file:// from showing up in the relative path.
Added test helper to update the expected value

How Has This Been Tested?

Ran tests locally and all passed.
Tested manually in Prism by manually changing the node_module files
Ran Prism tests locally and all passed.

Screenshot(s)/recordings(s)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@brendarearden brendarearden force-pushed the fix/2385-external-ref-resolution branch 3 times, most recently from 44adf1a to 154b8ba Compare September 26, 2023 15:44
@brendarearden brendarearden force-pushed the fix/2385-external-ref-resolution branch from 154b8ba to ae6977f Compare September 26, 2023 15:46
@brendarearden brendarearden requested review from a team and chohmann and removed request for a team September 26, 2023 16:50
@brendarearden brendarearden force-pushed the fix/2385-external-ref-resolution branch 6 times, most recently from 1a56a03 to 5bc1864 Compare September 26, 2023 21:27
@brendarearden brendarearden force-pushed the fix/2385-external-ref-resolution branch from 5bc1864 to ec34b4c Compare September 26, 2023 21:31
@brendarearden brendarearden force-pushed the fix/2385-external-ref-resolution branch from b27e339 to 4f5c085 Compare September 27, 2023 22:11
Copy link

@chohmann chohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo!

@brendarearden brendarearden force-pushed the fix/2385-external-ref-resolution branch 4 times, most recently from 1f64428 to 6377871 Compare September 28, 2023 20:09
@mmarti21 mmarti21 merged commit cdcfd4f into master Sep 29, 2023
@mmarti21 mmarti21 deleted the fix/2385-external-ref-resolution branch September 29, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants