Add several update #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
force-pushed
the
ffconf_custom
branch
from
b02ab47 to
cf19e53
Compare
Signed-off-by: Frederic.Pillon <[email protected]>
Add a file named "ffconf_custom.h" in the sketch folder will be used instead of the default config (ffconf_default.h). Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
fpistm
force-pushed
the
ffconf_custom
branch
from
cf19e53 to
835bb65
Compare
fpistm
changed the title
SD detect pin was hardcoded in sd_conf.h while API provide a way to specify it. This requires to provide the pin number instead of the GPIO_PIN_x pin and GPIOX port. That's why sd_conf.h has been removed from the core. Moreove several definition for the BSP are common or only dependent to SD instance. SD instance could be SDMMC1 or SDIO depending of the STM32 series. Only the SD detect definition should be redefined thanks the variant.h if the board has one. Signed-off-by: Frederic.Pillon <[email protected]>
Use Class methods with default parameters value. Signed-off-by: Frederic.Pillon <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
fpistm
force-pushed
the
ffconf_custom
branch
from
835bb65 to
32b7a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffconf.hto avoid embed it in the core and allow easiest user configThe FatFs has several user defined options, which is specified from within theffconf.hfile.This library provides a default user defined options file named
ffconf_default.h.User can provide his own defined options by adding his configuration in a file named
ffconf_custom.hat sketch level or in variant folder.sd_conf.hwhile API provide a way to specify it. This require to provide the pin number instead of theGPIO_PIN_xpin andGPIOX port.That's why
sd_conf.husage has been removed.Moreover several definition for the BSP are common or only dependent to SD instance.
SD instance could be
SDMMC1orSDIOdepending of the STM32 series.Only the SD detects definition should be redefined thanks the
variant.hif the board has one.begin()methods andBSP_SD_*init()functions: use methods with default parameters value.