PR1 review: Add STM32RTC library sources files #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
Unified enumerations definitions and hardened the code. Signed-off-by: Frederic.Pillon <[email protected]>
Use same methods with its default parameters value. * uint8_t getHours(RTC_AM_PM *period = NULL); * uint8_t getAlarmHours(RTC_AM_PM *period = NULL); Signed-off-by: Frederic.Pillon <[email protected]>
Add syncTime, syncDate and syncAlarmTime to factorize code. Signed-off-by: Frederic.Pillon <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
_day -> _wday is a week day (1 to 7) _date -> _day is the day (1 to 31) _alarmDate -> _alarmDay is the alarm day (1 to 31) Signed-off-by: Frederic.Pillon <[email protected]>
Before only MATCH_DHHMMSS was done. Signed-off-by: Frederic.Pillon <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
Added: isConfigured getPrediv setPrediv IS_CLOCK_SOURCE IS_HOUR_FORMAT MATCH_OFF MATCH_SS MATCH_MMSS MATCH_HHMMSS MATCH_DHHMMSS MATCH_MMDDHHMMSS MATCH_YYMMDDHHMMSS Updated enum value: RTC_HOUR_12 RTC_HOUR_24 RTC_AM RTC_PM Signed-off-by: Frederic.Pillon <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review of #1
This fix and enhance the preview PR:
begin()MATCH_DHHMMSSwas partially managed (match only one time not every month). Now all possible Alarm_Match value are handled.getHours(void)/getAlarmHours(void)Use same methods with its default parameters value.
uint8_t getHours(RTC_AM_PM *period = NULL);uint8_t getAlarmHours(RTC_AM_PM *period = NULL);syncTime()syncDate()syncAlarmTime()end()getPrediv()setPrediv