Use thread-safe memory manager using C runtime (Newlib) #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file from Dave Nadler: http://www.nadler.com/embedded/newlibAndFreeRTOS.html Signed-off-by: Frederic.Pillon <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
Use STM32 linker and FreeRTOS config definitions. Signed-off-by: Frederic.Pillon <[email protected]>
By default, the heap_useNewlib.c will be used. As suggested by @ppescher, use -1 as the number of heap implementations might grow in future versions. Signed-off-by: Frederic.Pillon <[email protected]>
|
I've tested these fixes on the Nucleo-L432KC, and they work perfectly. It would be helpful to get them released. (I should tell you that initially I thought that the fix didn't work. But as it turned out, my code was hitting a newlib _sbrk corruption issue. This issue is apparently fixed but needs to filter downstream. Specifically - the fix was committed to newlib in May/June of 2018 by Jeff Johnston. Apparently this must filter down into the ARM GNU toolchain. I can only hope that the upcoming end-of-year release includes the _sbrk newlib fix.) In any case, this is a great change and thank you for doing this work! |
configTOTAL_HEAP_SIZE could be not constant Signed-off-by: Frederic.Pillon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Dave Nadler works:
http://www.nadler.com/embedded/newlibAndFreeRTOS.html
and @ppescher suggestions in #9.
This new heap implementation will be used by default.
This also update default config to use linker definition:
This PR fix #8 and #9.