STM32Ethernet source files #1

ghost · 2017-07-04T09:26:15Z

STM32Ethernet source files for Ethernet library for STM32 cores and Arduino environment.

LMESTM

Looks ok - may be good to have some information inside the README.md as well.

fpistm · 2017-07-06T06:17:15Z

README.md

+## Ethernet Library for Arduino
+
+With an STM32 board with Ethernet compatibility, this library allows an STM32


Fix typo: an STM32

fpistm · 2017-07-06T06:19:12Z

README.md

+The library is based on LwIP, a Lightweight TCP/IP stack.
+http://git.savannah.gnu.org/cgit/lwip.git
+


Mention that LWIP has been ported as Arduino lib and this lib is dependent of this one

fpistm · 2017-07-06T06:20:01Z

examples/AdvancedChatServer/AdvancedChatServer.ino

+ by Norbert Truchsess
+ modified 23 Jun 2017
+ by Wi6Labs
+


Add dependency with LWIP lib from stm32duino (far all example)

fpistm · 2017-07-06T06:23:05Z

library.properties

+author=Various
+maintainer=STMicroelectronics
+sentence=Enables network connection (local and Internet) using the STM32 Board.
+paragraph=With this library you can use the STM32 board to connect to Internet. The library provides both Client and server functionalities. The library permits you to connect to a local network also with DHCP and to resolve DNS.


Mention LWIP stm23duino dependency

fpistm

Please; enable all compilers warning to ensure there is no one (at least for this lib)

fpistm · 2017-07-06T06:25:56Z

src/Dns.cpp

+    uint16_t acc = 0; // Accumulator
+    uint8_t dots = 0;
+
+    while (*address)


check if address is NULL

fpistm · 2017-07-06T06:27:43Z

src/Dhcp.h

+/* DHCP state machine. */
+#define STATE_DHCP_STOP				DHCP_OFF
+#define STATE_DHCP_START 			DHCP_START
+#define	STATE_DHCP_DISCOVER		DHCP_WAIT_ADDRESS


replace tab by space

fpistm · 2017-07-06T06:27:57Z

src/Dhcp.h

+private:
+  uint8_t  _dhcpMacAddr[6];
+  unsigned long _timeout;
+	uint8_t _dhcp_lease_state;


replace tab by space

fpistm · 2017-07-06T06:28:18Z

src/Dns.cpp

+
+#include "Dns.h"
+#include <string.h>
+//#include <stdlib.h>


remove comment

fpistm · 2017-07-06T06:29:55Z

src/Dns.cpp

+{
+  UNUSED(aName);
+    // Success!  Everything buffered okay
+    return 1;


please explain why always return 1 (deprecated?)

fpistm · 2017-07-06T06:32:02Z

src/EthernetClient.cpp

+  }
+
+  _tcp_client->pcb = NULL;
+  // _tcp_client->state = TCP_NONE;


fpistm · 2017-07-06T06:38:02Z

src/STM32Ethernet.cpp

+int EthernetClass::maintain(){
+  int rc = DHCP_CHECK_NONE;
+
+  // stm32_eth_scheduler();


remove or add more comment

fpistm · 2017-07-06T06:44:07Z

src/utility/ethernetif.c

+  ******************************************************************************
+  */
+/* Includes ------------------------------------------------------------------*/
+#include "stm32f4xx_hal.h"


Use generic include stm32_def.h

fpistm · 2017-07-06T06:49:18Z

src/utility/stm32_eth.c

+  /* Configure the Network interface */
+  Netif_Config();
+
+//TODO: juste temporaire pour debug: laisser à l'utilisateur la possibilité de l'utiliser


In English and explain more please

fpistm · 2017-07-06T06:51:03Z

src/utility/stm32_eth.c

+          pbuf_free(p);
+          p = q;
+          return p;
+        } else {


empty else ? to remove

Signed-off-by: fpr <[email protected]>

Add Ethernet interface for Arduino class. Signed-off-by: fpr <[email protected]>

…uino Ethernet library Signed-off-by: fpr <[email protected]>

Signed-off-by: fpr <[email protected]>

danieleff · 2017-07-22T04:38:25Z

src/utility/stm32_eth.h includes #include "stm32f4xx_hal.h"
Please include stm32_def.h instead

Signed-off-by: fpr <[email protected]>

ghost · 2017-07-24T07:23:49Z

Thank you @danieleff .
Fix done.

fpistm · 2017-07-07T12:50:17Z

src/Dhcp.h

-#define DEFAULT_LEASE	(900) //default lease time in seconds
+#define STATE_DHCP_STOP       DHCP_OFF
+#define STATE_DHCP_START      DHCP_START
+#define	STATE_DHCP_DISCOVER   DHCP_WAIT_ADDRESS


fpistm · 2017-08-16T06:28:19Z

examples/DhcpAddressPrinter/DhcpAddressPrinter.ino

+// Enter a MAC address for your controller below.
+// Newer Ethernet shields have a MAC address printed on a sticker on the shield
+byte mac[] = {
+  0x00, 0xAA, 0xBB, 0xCC, 0xDE, 0x02


Replace by
0xDE, 0xAD, 0xBE, 0xEF, 0xFE, 0xED

fpistm · 2017-08-16T06:28:51Z

examples/DhcpAddressPrinter/DhcpAddressPrinter.ino

+#include <STM32Ethernet.h>
+
+// Enter a MAC address for your controller below.
+// Newer Ethernet shields have a MAC address printed on a sticker on the shield


delete this line

fpistm · 2017-08-16T06:29:07Z

examples/DhcpChatServer/DhcpChatServer.ino

+// The IP address will be dependent on your local network.
+// gateway and subnet are optional:
+byte mac[] = {
+  0x00, 0xAA, 0xBB, 0xCC, 0xDE, 0x02


0xDE, 0xAD, 0xBE, 0xEF, 0xFE, 0xED

fpistm · 2017-08-16T06:29:47Z

examples/UdpNtpClient/UdpNtpClient.ino

+#include <EthernetUdp.h>
+
+// Enter a MAC address for your controller below.
+// Newer Ethernet shields have a MAC address printed on a sticker on the shield


delete this line

fpistm · 2017-08-16T06:30:06Z

examples/WebClient/WebClient.ino

+#include <STM32Ethernet.h>
+
+// Enter a MAC address for your controller below.
+// Newer Ethernet shields have a MAC address printed on a sticker on the shield


delete this line

Signed-off-by: fpr <[email protected]>

…CP_fails when DHCP fails the static IP can be appllied without problem

fpistm self-requested a review July 5, 2017 13:47

fpistm assigned fpistm and ghost and unassigned fpistm Jul 5, 2017

fpistm requested a review from LMESTM July 5, 2017 13:48

LMESTM reviewed Jul 5, 2017

View reviewed changes

fpistm reviewed Jul 6, 2017

View reviewed changes

fpr added 9 commits July 6, 2017 16:10

Initial source files come from Ethernet library of Arduino 1.8.3

febc2e2

Signed-off-by: fpr <[email protected]>

Update Arduino library properties

6935488

Signed-off-by: fpr <[email protected]>

Add Ethernet network driver for LwIP from STM32Cube_FW_F4_V1.16.0

da88563

Signed-off-by: fpr <[email protected]>

Update Ethernet driver for STM32 Arduino.

ddc0fd1

Add Ethernet interface for Arduino class. Signed-off-by: fpr <[email protected]>

Rename library entry files to keep compatibility with the default Ard…

b8f8332

…uino Ethernet library Signed-off-by: fpr <[email protected]>

Update library classes for STM32

1f95d13

Signed-off-by: fpr <[email protected]>

Remove unused files

79d3d62

Signed-off-by: fpr <[email protected]>

Modify examples for the STM32Ethernet library

f5fecc7

Signed-off-by: fpr <[email protected]>

Update library documentation

e02d9ed

Signed-off-by: fpr <[email protected]>

Replaced specific HAL include with generic one

e641f84

Signed-off-by: fpr <[email protected]>

fpistm reviewed Aug 11, 2017

View reviewed changes

fpistm reviewed Aug 16, 2017

View reviewed changes

Use the same MAC address in all sketches and remove comments outdated.

2cbafb0

Signed-off-by: fpr <[email protected]>

fpistm merged commit 4c7d80e into stm32duino:master Aug 16, 2017

fpistm mentioned this pull request Aug 16, 2017

Stm32 ethernet lib stm32duino/Arduino_Core_STM32#38

Closed

nopnop2002 mentioned this pull request Jul 24, 2019

Support LAN8720 PHY #23

Closed

ABOSTM pushed a commit to ABOSTM/STM32Ethernet that referenced this pull request Mar 1, 2022

Merge pull request stm32duino#1 from Solairseir/fix_staticIP_after_DH…

c9e6d74

…CP_fails when DHCP fails the static IP can be appllied without problem

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STM32Ethernet source files #1

STM32Ethernet source files #1

ghost commented Jul 4, 2017

LMESTM left a comment

fpistm Jul 6, 2017

fpistm Jul 6, 2017

fpistm Jul 6, 2017 •

edited

Loading

fpistm Jul 6, 2017

fpistm left a comment

fpistm Jul 6, 2017

fpistm Jul 6, 2017

fpistm Jul 6, 2017

fpistm Jul 6, 2017

fpistm Jul 6, 2017

fpistm Jul 6, 2017

fpistm Jul 6, 2017

fpistm Jul 6, 2017

fpistm Jul 6, 2017

fpistm Jul 6, 2017

danieleff commented Jul 22, 2017

ghost commented Jul 24, 2017

fpistm Jul 7, 2017

fpistm Aug 16, 2017

fpistm Aug 16, 2017

fpistm Aug 16, 2017

fpistm Aug 16, 2017

fpistm Aug 16, 2017

		## Ethernet Library for Arduino

		With an STM32 board with Ethernet compatibility, this library allows an STM32

		The library is based on LwIP, a Lightweight TCP/IP stack.
		http://git.savannah.gnu.org/cgit/lwip.git

STM32Ethernet source files #1

STM32Ethernet source files #1

Conversation

ghost commented Jul 4, 2017

LMESTM left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fpistm Jul 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fpistm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danieleff commented Jul 22, 2017

ghost commented Jul 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fpistm Jul 6, 2017 •

edited

Loading