Skip to content

Harden shell scripts #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2020
Merged

Harden shell scripts #56

merged 3 commits into from
Mar 5, 2020

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Mar 4, 2020

  • Unified shell script name across host and add missing extension
  • Make shell scripts ShellCheck compliant
  • Use shfmt to format shell scripts
  • Add the formatting options file

@fpistm fpistm added the enhancement New feature or request label Mar 4, 2020
fpistm added 3 commits March 4, 2020 17:20
@fpistm
Unified shell script name across host and add missing extension
52b5a4a 
Signed-off-by: Frederic Pillon <[email protected]>
@fpistm
Make shell scripts ShellCheck compliant
e00ca18 
Signed-off-by: Frederic Pillon <[email protected]>
@fpistm
Use shfmt to format shell scripts
f9f5b25 
Add the formatting options file

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm fpistm self-assigned this Mar 4, 2020
@fpistm fpistm added this to the 1.4.0 milestone Mar 4, 2020
@fpistm fpistm mentioned this pull request Mar 4, 2020
Merged
@fpistm
Copy link
Member Author

fpistm commented Mar 4, 2020

@kbumsik
I've made some change i the run_arduino_gen.sh to be compliant with ShellCheck.
I've tested and it works anyway if you can review it and give your feedback, this will be really appreciate.
Thanks in advance.

@kbumsik
Copy link
Contributor

kbumsik commented Mar 4, 2020

@fpistm LGTM, I tested it on my hardware and it works well too.
It is interesting that echo -n is not POSIX compliant though.

@fpistm
Copy link
Member Author

fpistm commented Mar 5, 2020

Thanks @kbumsik

It is interesting that echo -n is not POSIX compliant though.

Yes it is.

@fpistm fpistm merged commit e00d1d7 into stm32duino:master Mar 5, 2020
@fpistm fpistm deleted the hardening branch March 5, 2020 07:00
@fpistm fpistm mentioned this pull request Mar 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fpistm fpistm

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fpistm @kbumsik