-
Notifications
You must be signed in to change notification settings - Fork 1k
Nucleo-144 F756ZG #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nucleo-144 F756ZG #963
Conversation
Hi @hockeymikey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hockeymikey,
Thanks for this PR.
Globally that fine, nevertheless few remarks:
- Can you please run Astyle to format code
- There is a missing part : declare the new board in board.txt file
see https://github.com/stm32duino/wiki/wiki/Add-a-new-variant-(board)#8---declare-the-variant - also see inline comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hockeymikey ,
Thanks for this update.
There are some remarks that are still valid:
- variant.h
Chip STM32F756ZG has 8 sectors and Flash base address of last sector is 0x080C0000
Also update comment : 1MB of flash
- PeripheralPins.c
It looks like you mixed with some F767:
On F756 PA_15 doesn't have UART7 alternate function.
... this is the original one:
https://github.com/stm32duino/Arduino_Tools/blob/master/src/genpinmap/Arduino/STM32F7/STM32F756ZGTx/PeripheralPins.c
This is valid for UART, SPI, CAN and QUADSPI arrays.
f0f8849
to
6e739cd
Compare
Hi @hockeymikey , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hockeymikey ,
I don't know what you intend to do, but it looks like variant.cpp has duplicated code, and the same for variant.h.
@hockeymikey |
Summary
Adds the Nucleo-144 F756ZG variant board. https://www.st.com/en/evaluation-tools/nucleo-f756zg.html
Validation
Tested on the board I had and blink ran fine. Would be great for someone to just double check my work since it's my first rodeo.