Skip to content

Nucleo-144 F756ZG #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Conversation

hockeymikey
Copy link
Contributor

Summary

Adds the Nucleo-144 F756ZG variant board. https://www.st.com/en/evaluation-tools/nucleo-f756zg.html

Validation

Tested on the board I had and blink ran fine. Would be great for someone to just double check my work since it's my first rodeo.

@fpistm fpistm added the new variant Add support of new bard label Mar 3, 2020
@fpistm
Copy link
Member

fpistm commented Mar 3, 2020

Hi @hockeymikey
Thanks for the PR.

@fpistm fpistm requested a review from ABOSTM March 3, 2020 06:49
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hockeymikey,
Thanks for this PR.
Globally that fine, nevertheless few remarks:

Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hockeymikey ,
Thanks for this update.
There are some remarks that are still valid:

  • variant.h

Chip STM32F756ZG has 8 sectors and Flash base address of last sector is 0x080C0000
Also update comment : 1MB of flash

  • PeripheralPins.c

It looks like you mixed with some F767:
On F756 PA_15 doesn't have UART7 alternate function.
... this is the original one:
https://github.com/stm32duino/Arduino_Tools/blob/master/src/genpinmap/Arduino/STM32F7/STM32F756ZGTx/PeripheralPins.c

      This is valid for UART, SPI, CAN and QUADSPI arrays.

@hockeymikey hockeymikey force-pushed the master branch 2 times, most recently from f0f8849 to 6e739cd Compare March 18, 2020 03:19
@ABOSTM
Copy link
Contributor

ABOSTM commented Mar 21, 2020

Hi @hockeymikey ,
I take the liberty to continue your Pull Request, specially to merge the support of NUCLEO_F746ZG #999 which is very similar to NUCLEO_F756ZG and can use the same variant.
The only difference between both is that F756 embed cryptographic accelerators AES and CRYP, that are not currently supported by Arduino.

@ABOSTM ABOSTM mentioned this pull request Mar 21, 2020
8 tasks
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hockeymikey ,
I don't know what you intend to do, but it looks like variant.cpp has duplicated code, and the same for variant.h.

@fpistm
Copy link
Member

fpistm commented Mar 26, 2020

@hockeymikey
I've made a mistake while updating your PR.
I've sync your dork master with the original repo that's why this PR was closed automatically.
Anyway, I've submitted the clean PR in #1014.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants