-
Notifications
You must be signed in to change notification settings - Fork 1k
USB reworked #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USB reworked #91
Conversation
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
…nt and moved HID descriptors inside the library Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
…et the flag USBCON. No more specific flag per USB class. Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Are you going to add NUCELO-F103RB, BluePill and MapleMini to this or do I have to manually merge those changes? |
@RickKimball goal is to have all merged. This PR is a first proposal version from Fabien to manage USB features:
Still to include DFU. I have to benchmark and review this PR to see if it could be applicable. Mainly around USB performance as in @rogerclarkmelbourne core several works have been done to enhance it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the Arduino library guideline: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#source-code
Source code of a library should be in 'src/' directory
- USBHIDComposite
- USBSerial
Signed-off-by: fpr <[email protected]>
Done! I added src directory in libraries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One blocking thing is about the need to #include <USBSerial.h> to have the SerialUSB.
This will break several sketch compatibility
We have the solution to propose this library by default (not an external library) and include USBSerial.h in the Arduino.h. And add the flag USBCON to avoid compilation when USB is not used. What do you think? |
Approved by error. Still some review to perform
I am using 2017.9.22 release. This version doesn't support USB for STML0 CPU. |
Hope soon, currently working on it as a background task. |
That's great. Thanks for quick response. |
is usb-cdc working for stm32f411 in the current release? |
Currently not. It will be one of the next feature to add |
OK. Even mbed lacks, last time I checked. |
In fact, it was functionnal, but required some clean. First will be to rebsse it properly |
I close this one to not pollute the list of PR and bring confusion. |
USB configuration is more generic and free of the core.
It is easier to import new USB class from a library.
HIDComposite has been moved inside an independent library used by Keyboard and Mouse libraries.
USBSerial has been moved inside is own library too.
USBSerial must be tested with BluePill and Maple Mini boards.
"USB interface" menu is now only used to enable USB.
Suggestions are welcome.