Skip to content

USB reworked #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 29 commits into from
Closed

USB reworked #91

wants to merge 29 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2017

USB configuration is more generic and free of the core.
It is easier to import new USB class from a library.

HIDComposite has been moved inside an independent library used by Keyboard and Mouse libraries.
USBSerial has been moved inside is own library too.

USBSerial must be tested with BluePill and Maple Mini boards.

"USB interface" menu is now only used to enable USB.

Suggestions are welcome.

fpr and others added 28 commits August 23, 2017 14:37
…nt and moved HID descriptors inside the library

Signed-off-by: fpr <[email protected]>
…et the flag USBCON. No more specific flag per USB class.

Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
@RickKimball
Copy link
Contributor

RickKimball commented Aug 23, 2017

Are you going to add NUCELO-F103RB, BluePill and MapleMini to this or do I have to manually merge those changes?

@fpistm
Copy link
Member

fpistm commented Aug 24, 2017

@RickKimball goal is to have all merged. This PR is a first proposal version from Fabien to manage USB features:

  • HID
  • CDC
  • USBMicrophone (which is ongoing and will be available here USBMicrophone

Still to include DFU.

I have to benchmark and review this PR to see if it could be applicable. Mainly around USB performance as in @rogerclarkmelbourne core several works have been done to enhance it.
FYI Fabien is out of office during 1 week so don't worry if he will not answer during this period.

@fpistm fpistm self-requested a review September 4, 2017 12:44
@fpistm fpistm added enhancement New feature or request help wanted 🙏 Extra attention is needed labels Sep 4, 2017
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the Arduino library guideline: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#source-code

Source code of a library should be in 'src/' directory

  • USBHIDComposite
  • USBSerial

@ghost
Copy link
Author

ghost commented Sep 6, 2017

Done! I added src directory in libraries.

fpistm
fpistm previously approved these changes Sep 6, 2017
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking thing is about the need to #include <USBSerial.h> to have the SerialUSB.
This will break several sketch compatibility

@ghost
Copy link
Author

ghost commented Sep 6, 2017

We have the solution to propose this library by default (not an external library) and include USBSerial.h in the Arduino.h. And add the flag USBCON to avoid compilation when USB is not used. What do you think?

@fpistm fpistm dismissed their stale review September 6, 2017 15:17

Approved by error. Still some review to perform

@fpistm fpistm added this to the Next release milestone Sep 29, 2017
@chwon64
Copy link

chwon64 commented Oct 16, 2017

I am using 2017.9.22 release. This version doesn't support USB for STML0 CPU.
Do you have plan when it will be supported?

@fpistm
Copy link
Member

fpistm commented Oct 16, 2017

Hope soon, currently working on it as a background task.

@chwon64
Copy link

chwon64 commented Oct 16, 2017

That's great. Thanks for quick response.

@fpistm fpistm removed this from the Next release milestone Jan 31, 2018
@hei5enbrg
Copy link

is usb-cdc working for stm32f411 in the current release?

@fpistm
Copy link
Member

fpistm commented Feb 6, 2018

Currently not. It will be one of the next feature to add

@hei5enbrg
Copy link

OK. Even mbed lacks, last time I checked.
I'll have to use stmcube APIs then. Thanks

@fpistm
Copy link
Member

fpistm commented Feb 6, 2018

In fact, it was functionnal, but required some clean. First will be to rebsse it properly

@fpistm
Copy link
Member

fpistm commented Dec 22, 2018

I close this one to not pollute the list of PR and bring confusion.
Moreover this one is referenced by #388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned No more work on this enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants