Skip to content

Solves #869 #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Solves #869 #870

wants to merge 2 commits into from

Conversation

EliasKotlyar
Copy link

@EliasKotlyar EliasKotlyar commented Jan 13, 2020 •
edited
Loading

Pull Request template

Summary

This PR fixes/implements the following bugs/features

#869

@fpistm fpistm added the new variant Add support of new bard label Jan 14, 2020
@fpistm
Copy link
Member

fpistm commented Feb 4, 2020

@EliasKotlyar
Your PR is not able to build.
You claim in #869 :

However it does not solve the problem. Blink is not working, normal LEDs on/off are working fine.

I don't know how you can test it as it could not build properly.
So, please fix the astyle formatting issue and the build issue then I will review it.

@fpistm fpistm added invalid This doesn't seem right waiting feedback Further information is required labels Feb 4, 2020
@fpistm
Copy link
Member

fpistm commented Feb 13, 2020

@EliasKotlyar
please fix all issue:

  • code formatting (Astyle)
  • all build issue

I don't understand how you can test your variant as it could not build properly.
Without any update, I will close this PR as not at expected level.

fpistm
fpistm requested changes Feb 14, 2020
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is not well formed and seems not tested.
I close this PR as not as expected level.

@fpistm
Copy link
Member

fpistm commented Feb 14, 2020

Please as request several time ensure your PR build before submit it.

@fpistm fpistm closed this Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm requested changes

Assignees
No one assigned
Labels
invalid This doesn't seem right new variant Add support of new bard waiting feedback Further information is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EliasKotlyar @fpistm