Skip to content

Add STM32G0316-DISCO #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add STM32G0316-DISCO #863

wants to merge 4 commits into from

Conversation

DurandA
Copy link
Contributor

@DurandA DurandA commented Jan 8, 2020

This PR adds the STM32G0316-DISCO variant which is based on a STM32G0 in SO8 package.

Fix #858. This is a draft PR as I want to gather some feedback from the maintainers first.

@DurandA
Copy link
Contributor Author

DurandA commented Jan 8, 2020

Hi @fpistm, I have a few questions before the PR is ready (and I need to test it properly):

  • How is is used .node from boards.txt? What value should I use for Disco.menu.pnum.DISCO_G0316.node?
  • As discussed in [New Variant] STM32G0316-DISCO #858, there is no serial line that goes to the ST-Link in this board. It requires to connect an external serial adapter in order to use USART1 (which is the only UART interface in this MCU except LPUART1 but no RX pin is available on the STM32G031J6 for LPUART1). Is it preferred to completely remove Serial definitions in variant.h?

fpistm and others added 2 commits January 10, 2020 17:45
@DurandA
Copy link
Contributor Author

DurandA commented Jan 14, 2020

Hi @fpistm, thank you for your patch.

There were many fixes! One of the issues I had is that I misunderstood the comment All pins are digital, analog inputs are a subset of digital pins. from variant.h of the board_template. I interpreted it as analogInputPin[] is a subset of digitalPin[] so I thought that analogInputPin[] contained indices from digitalPin[], or the starting index of digitalPin[] if NUM_ANALOG_FIRST was used.

I will do some testing in the next few days so you can merge this. If you already tested it and you think it is ready to merge, I marked the PR as ready for review.

Many thanks!

@DurandA DurandA marked this pull request as ready for review January 14, 2020 11:51
@fpistm fpistm self-requested a review February 3, 2020 16:13
@fpistm fpistm mentioned this pull request Feb 3, 2020
@fpistm fpistm added abandoned No more work on this new variant Add support of new bard labels Feb 3, 2020
@fpistm
Copy link
Member

fpistm commented Feb 3, 2020

Hi @DurandA
I close this one as too much conflict.
I've made a new one with pin remap handling: #913

@fpistm fpistm closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned No more work on this new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Variant] STM32G0316-DISCO
2 participants