Skip to content

Pin name PXn could be used instead of Dx #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2017
Merged

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Aug 17, 2017

With this PR the following call are equivalent (for Nucleo F429ZI):

Digital:

digitalWrite(33, HIGH); 
digitalWrite(D33, HIGH);
digitalWrite(PB0, HIGH);
digitalWrite(pinNametoDigitalPin(PB_0), HIGH);

AnalogRead:

analogRead(A0);
analogRead(0);
analogRead(PA3);
analogRead(pinNametoDigitalPin(PA_3));
analogRead(D78);
analogRead(78);

AnalogWrite:

analogWrite(A0);
analogWrite(PA3);
analogWrite(pinNametoDigitalPin(PA_3));
analogWrite(D78);
analogWrite(78);

Warning analogWrite(0); write on D0 (PG9)

@fpistm fpistm requested a review from a user August 17, 2017 10:05
@fpistm fpistm self-assigned this Aug 17, 2017
@fpistm fpistm added the enhancement New feature or request label Aug 17, 2017
@fpistm fpistm added this to the next release milestone Aug 17, 2017
@RickKimball
Copy link
Contributor

This is great. I didn't think you'd want to go through and change everything
+1

Are you going to also modify the STM32F1_merge_Other branch files also?

@fpistm
Copy link
Member Author

fpistm commented Aug 17, 2017

This is great. I didn't think you'd want to go through and change everything

In fact, there is not so much changes. Since I've reviewed pin managements for Firmata, it's easy to manage it properly.

Are you going to also modify the STM32F1_merge_Other branch files also?

Off course @RickKimball
It is always planned to merge the BP and the MM.
We currently review USB part with @fprwi6labs

I'm waiting feedback before merge this PR. Then I will update the STM32F1_merge_Other branch

@fpistm fpistm merged commit 8433db3 into stm32duino:master Aug 18, 2017
@fpistm fpistm deleted the pinnaming branch August 18, 2017 08:59
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Aug 18, 2017
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Aug 21, 2017
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Aug 21, 2017
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Aug 24, 2017
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Aug 30, 2017
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Sep 1, 2017
@ghost ghost mentioned this pull request Sep 12, 2017
lacklustrlabs pushed a commit to lacklustrlabs/Arduino_Core_STM32 that referenced this pull request Jan 19, 2018
lacklustrlabs pushed a commit to lacklustrlabs/Arduino_Core_STM32 that referenced this pull request Jan 23, 2018
lacklustrlabs pushed a commit to lacklustrlabs/Arduino_Core_STM32 that referenced this pull request Jan 27, 2018
lacklustrlabs pushed a commit to lacklustrlabs/Arduino_Core_STM32 that referenced this pull request Jan 27, 2018
lacklustrlabs pushed a commit to lacklustrlabs/Arduino_Core_STM32 that referenced this pull request Jan 29, 2018
lacklustrlabs pushed a commit to lacklustrlabs/Arduino_Core_STM32 that referenced this pull request Jan 31, 2018
lacklustrlabs pushed a commit to lacklustrlabs/Arduino_Core_STM32 that referenced this pull request Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants