-
Notifications
You must be signed in to change notification settings - Fork 1k
Added Elektor LoRa Node ( STM32F072 based ) #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds board support for Elektor LoRa Node with STM32F072 MCU
Hi @lab-mathias-claussen |
Board is now within the LoRa section
Hi, the board is moved, currently i struggle with the "board discription", i guess it's not meant in the board.txt but somewhere here ? Schematics and KiCad Files can be found here : https://github.com/ElektorLabs/180516-Elektor_LoRa_Node Project discrition can be found here: https://www.elektormagazine.com/labs/lorawan-node-experimental-platform |
Thanks @lab-mathias-claussen For the board description, this is mainly to review the variant (pin mapping, ...) and having a link to add in the README.md if this PR is merged. |
Hi, the board.txt should be fixed now. I am sorry for the messed up board.txt. |
Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
Even if not available in in LQFP48 package. Signed-off-by: Frederic Pillon <[email protected]>
Remove useless comments Fix typo Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
PR 810 review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lab-mathias-claussen
I forgot to check duplicated pins in the PeripheralPins.c
See my comment, this will allow to save space.
Co-Authored-By: Frederic Pillon <[email protected]>
Duplicated PINS in PeripheralsPins.c have been commented out,.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lab-mathias-claussen
Simply remove the ADC_RESOLUTION definition and this will be ok.
Co-Authored-By: Frederic Pillon <[email protected]>
Co-Authored-By: Frederic Pillon <[email protected]>
Co-Authored-By: Frederic Pillon <[email protected]>
Co-Authored-By: Frederic Pillon <[email protected]>
Co-Authored-By: Frederic Pillon <[email protected]>
AStyle fixed as travis build failed
This adds board support for Elektor LoRa Node with STM32F072 MCU