Skip to content

Added Elektor LoRa Node ( STM32F072 based ) #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Dec 3, 2019
Merged

Added Elektor LoRa Node ( STM32F072 based ) #810

merged 18 commits into from
Dec 3, 2019

Conversation

lab-mathias-claussen
Copy link
Contributor

@lab-mathias-claussen lab-mathias-claussen commented Dec 2, 2019

This adds board support for Elektor LoRa Node with STM32F072 MCU

This adds board support for Elektor LoRa Node with STM32F072 MCU
@fpistm fpistm added the new variant Add support of new bard label Dec 2, 2019
@fpistm
Copy link
Member

fpistm commented Dec 2, 2019

Hi @lab-mathias-claussen
thanks for this PR.
Please, could you add it under "Lora Boards" menu instead of create new item menu.
Could you provide a link the the board description (User manual, schematics,...)?
Thanks

Board is now within the LoRa section
@lab-mathias-claussen
Copy link
Contributor Author

lab-mathias-claussen commented Dec 2, 2019

Hi, the board is moved, currently i struggle with the "board discription", i guess it's not meant in the board.txt but somewhere here ?

Schematics and KiCad Files can be found here : https://github.com/ElektorLabs/180516-Elektor_LoRa_Node

Project discrition can be found here: https://www.elektormagazine.com/labs/lorawan-node-experimental-platform

@fpistm
Copy link
Member

fpistm commented Dec 2, 2019

Thanks @lab-mathias-claussen
anyway it seems you made a mistake when updating the boards.txt as it includes lot of changes not related to the new variant.

For the board description, this is mainly to review the variant (pin mapping, ...) and having a link to add in the README.md if this PR is merged.

@lab-mathias-claussen
Copy link
Contributor Author

Hi,

the board.txt should be fixed now. I am sorry for the messed up board.txt.

fpistm and others added 6 commits December 2, 2019 14:55
Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
Even if not available in in LQFP48 package.

Signed-off-by: Frederic Pillon <[email protected]>
Remove useless comments
Fix typo

Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lab-mathias-claussen
I forgot to check duplicated pins in the PeripheralPins.c
See my comment, this will allow to save space.

lab-mathias-claussen and others added 2 commits December 2, 2019 16:33
Duplicated PINS in PeripheralsPins.c have been commented out,.
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lab-mathias-claussen
Simply remove the ADC_RESOLUTION definition and this will be ok.

AStyle fixed as travis build failed
@fpistm fpistm merged commit ad09a48 into stm32duino:master Dec 3, 2019
@fpistm fpistm added this to the 1.8.0🎄 🎅 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants