New board definition: Piconomix PX-HER0 board (STM32L072RB)

[pieterconradie]

Hi there!

This is my first time working with stm32duino and adding a new variant, so all pointers / tips / hints will be much appreciated!

Thanks in advance,
Pieter
https://piconomix.com

[fpistm]

Hi @pieterconradie
thanks for this PR.
I will made a review.
I guess this is this board:
https://github.com/piconomix/piconomix-fwlib/tree/master/boards/arm/stm32/piconomix_hero_board

[fpistm]

First review, I will deeply reviewed after all required first review comments will be fixed.
Please also fix code formatting issue. You can use Astyle to ensure all is OK and avoid Astyle check failure.
See https://github.com/stm32duino/wiki/wiki/Astyle

[fpistm]

@pieterconradie
Thanks for the update.
Anyway, I would prefer PX_HER0 instead of PX-HER0.
I don't know how the "-" could be interpreted if it is used in a command line. So please use "_".

[pieterconradie]

Hi @fpistm Thanks for the guidance :) The "astyle.py" script did not work for me so I ran Astyle manually to fix the files. Hope all is OK now. Thanks! Pieter

[pieterconradie]

Hi @fpistm I got the astyle.py script working for me and the pull request is now passing the CI checks :) Best regards, Pieter

[fpistm]

At least remove SD card related line in variant.h.

[pieterconradie]

Hi @fpistm Thanks for the advice :) I have made the changes. If you are interested the board design files (including schematic) are HERE. My test sketches are HERE

[fpistm]

LGTM
I do not have this board so I assume you test it. 😉

[fpistm]

I will merge it and add a reference in the README.md. Could you give me a link I can add to reference the board, please?

[pieterconradie]

Hi @fpistm Thank you kindly for your help and merging the code :) HERE is a link to the board.

[fpistm]

@pieterconradie
Thanks, The README.md has been updated.