-
Notifications
You must be signed in to change notification settings - Fork 1k
MP1 update #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MP1 update #774
Conversation
Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
in engineering mode only. Signed-off-by: Frederic Pillon <[email protected]>
Yes. I tested it. diff --git a/run_arduino_gen.sh b/run_arduino_gen.sh
index 3b67ecba..2704625f 100755
--- a/run_arduino_gen.sh
+++ b/run_arduino_gen.sh
@@ -219,10 +219,11 @@ case "$1" in
TERM=xterm minicom -D $RPMSG_DIR
;;
generate)
- generate_packaged_script $2 $3
- echo "$(readlink -f "$3") generated successfully."
+ output=$(echo "$3" | sed 's/\.ino\././g')
+ generate_packaged_script $2 $output
+ echo "$(readlink -f "$output") generated successfully."
echo "This file should be uploaded manually by SCP, SFTP, Kermit, or etc."
- echo "Then run \"sh ./$(basename $3) start\" command in the board's console."
+ echo "Then run \"sh ./$(basename $output) start\" command in the board's console."
echo "For detailed instructions, please visit:"
echo " https://github.com/stm32duino/Arduino_Core_STM32/tree/master/variants/STM32MP157_DK/README.md"
;; should work, tested in Linux and Windows. |
Well, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just spotted some while I read through the rendered README.md. It should be fine for me otherwise.
Co-Authored-By: Bumsik Kim <[email protected]> Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
https://github.com/STMicroelectronics/STM32CubeMP1/releases/tag/1.1.1 Signed-off-by: Frederic Pillon <[email protected]>
This PR:
[New variant] STM32MP157_DK #717 (comment)
I will probably also update the generated script name with the sketch name.Done@kbumsik as discussed in stm32duino/Arduino_Tools#47 (comment), do you think it is correct to use sed in the generate part of the script?
Maybe I will add theMP1 Cube update 1.1.1: