-
Notifications
You must be signed in to change notification settings - Fork 1k
[Timer] Add getHandle function #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to to me.
Would be great if you could update also wiki page accordingly:
https://github.com/stm32duino/wiki/wiki/HardwareTimer-library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix astyle issue:
https://travis-ci.com/stm32duino/Arduino_Core_STM32/jobs/256052273
Note that users who use this function and modify the Timer handle will use it at their own risk. No support will be provided if Hardware Timer does not work as expected after Timer handle custom change. |
b955c66
to
06cf934
Compare
Wh00ps, OK sorry about that. Is this better @fpistm?
I added an extra note in the cpp file, hopefully that is enough. |
Fine for the comment except the astyle issue linked to it 😉 (Trailing space) |
06cf934
to
cebc5b3
Compare
This enables users to config timers using the HAL layers for more advanced timer settings when needed. This is especially useful when multiple timer channels require separate configurations under the same timer instance.
cebc5b3
to
0faf7b7
Compare
This enables users to config timers using the HAL layers for more advanced timer
settings when needed. This is especially useful when multiple timer channels
require separate configurations under the same timer instance.
This feature is related to issue #763