Skip to content

[Timer] Add getHandle function #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019
Merged

[Timer] Add getHandle function #771

merged 1 commit into from
Nov 14, 2019

Conversation

HendryKaak
Copy link

This enables users to config timers using the HAL layers for more advanced timer
settings when needed. This is especially useful when multiple timer channels
require separate configurations under the same timer instance.

This feature is related to issue #763

@fpistm fpistm requested a review from ABOSTM November 13, 2019 12:03
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to to me.
Would be great if you could update also wiki page accordingly:
https://github.com/stm32duino/wiki/wiki/HardwareTimer-library

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpistm
Copy link
Member

fpistm commented Nov 14, 2019

Note that users who use this function and modify the Timer handle will use it at their own risk. No support will be provided if Hardware Timer does not work as expected after Timer handle custom change.

@HendryKaak
Copy link
Author

Wh00ps, OK sorry about that. Is this better @fpistm?

Note that users who use this function and modify the Timer handle will use it at their own risk. No support will be provided if Hardware Timer does not work as expected after Timer handle custom change.

I added an extra note in the cpp file, hopefully that is enough.

@fpistm
Copy link
Member

fpistm commented Nov 14, 2019

Fine for the comment except the astyle issue linked to it 😉 (Trailing space)
https://travis-ci.com/stm32duino/Arduino_Core_STM32/jobs/256462599

This enables users to config timers using the HAL layers for more advanced timer
settings when needed. This is especially useful when multiple timer channels
require separate configurations under the same timer instance.
@fpistm fpistm added the enhancement New feature or request label Nov 14, 2019
@fpistm fpistm added this to the 1.8.0🎄 🎅 milestone Nov 14, 2019
@fpistm fpistm merged commit 7e2f4f6 into stm32duino:master Nov 14, 2019
@HendryKaak HendryKaak deleted the getHandle branch November 14, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants