Skip to content

Revert "Added the repeated-start feature in I2C driver" #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Sep 23, 2019

During Non regression tests for 1.7.0 found an issue on STM32 F2 and F4 series due to #590 introduction. Using I2C EEPROM failed.
So, reverts #590

@fpistm fpistm added bug 🐛 Something isn't working fix 🩹 Bug fix labels Sep 23, 2019
@fpistm fpistm self-assigned this Sep 23, 2019
@fpistm fpistm added this to the 1.7.0 milestone Sep 23, 2019
@fpistm fpistm merged commit 0c87941 into master Sep 23, 2019
@fpistm fpistm deleted the revert-590-master branch September 23, 2019 11:54
fpistm pushed a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Oct 31, 2019
When NACK is received by master, instead of immediate re-transmission
by twi driver, error is reported. Up to application to manage
re-transmission.

This fix regression found on STM32F2 and STM32F4 when using I2C_OTHER_FRAME.
See PR stm32duino#663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working fix 🩹 Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant