Skip to content

Replaced hard coded EEPROM base address with generic code #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Jul 13, 2017
Merged

Replaced hard coded EEPROM base address with generic code #64

merged 2 commits into from Jul 13, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 13, 2017

Patch following a problem encountered in #56.
Hard coded addresses has been replaced with more generic code definition.

@fpistm the F7 and F2 need to be tested! Other are OK.

@ghost ghost requested a review from fpistm July 13, 2017 10:34
@ghost ghost added the enhancement New feature or request label Jul 13, 2017
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code could be factorize:

F0 and F1
F2 F4 and F7

@ghost
Copy link
Author

ghost commented Jul 13, 2017

Modification done!

@fpistm fpistm merged commit 2faafda into stm32duino:master Jul 13, 2017
@ghost ghost deleted the EEPROM_patch branch September 19, 2017 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant