Skip to content

[I2C] Add general call mode settings #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2019

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jun 14, 2019

This PR add possibility to enable the I2C general call mode feature.
It replaces #470 .

Adding true to the 3 Wire::begin() methods will enable the general call mode else false per default.

/cc @benwaffle

fpistm added 3 commits June 14, 2019 10:40
Available in i2c_t structure field isMaster

Signed-off-by: Frederic.Pillon <[email protected]>
Adding true to the 3 Wire::begin() method will enable the
general call mode else false per default.

Signed-off-by: Frederic.Pillon <[email protected]>
@fpistm fpistm added the enhancement New feature or request label Jun 14, 2019
@fpistm fpistm added this to the 1.6.0 milestone Jun 14, 2019
@fpistm fpistm requested a review from LMESTM June 14, 2019 09:20
@fpistm fpistm self-assigned this Jun 14, 2019
Copy link
Member

@LMESTM LMESTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Maybe there could be a short comment or example to explain how to use this newly introduced way to use the API ?

@uzi18
Copy link

uzi18 commented Jun 14, 2019

@LMESTM it looks like if you need to enable general call mode feature, just add parameter "true" to begin, like:
Wire.begin(true); or Wire.begin(0x70,true);

@fpistm
Copy link
Member Author

fpistm commented Jun 14, 2019

I've planned to add in the Wiki after merge:
https://github.com/stm32duino/wiki/wiki/API#i2c

@fpistm fpistm merged commit 4a2947a into stm32duino:master Jun 15, 2019
@fpistm fpistm deleted the I2C_generalCallMode branch June 15, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants