Ethernet f4 #52
Merged
Ethernet f4 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 4, 2017 11:12
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
Adds Ethernet main function in core. It is empty if STM32Ethernet not called. Signed-off-by: fpr <[email protected]>
Changes PHY configuration to match with the good one. Signed-off-by: fpr <[email protected]>
fpistm
reviewed
Aug 12, 2017
| @@ -45,6 +45,9 @@ int main( void ) | |||
|
|
|||
| for (;;) | |||
| { | |||
| // Define by Ethernet library. It is defined as __weak. | |||
| stm32_eth_scheduler(); | |||
There was a problem hiding this comment.
Think about add registration callback mechanism during instance init. This way it was more generic and usable for further lib
Closed
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR must replace #38 because we isolated the STM32Ethernet & LwIP libraries in independent repositories.
This PR adds Ethernet feature for all cores and Ethernet configuration for NUCLEO-F429ZI variant.