Generic Serial #424
Merged
Generic Serial #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As generic "Serial" and "serialEvent" could be used by HardwareSerial or USBSerial, defaut definition have to be move away from uart to be properly wired. Signed-off-by: Frederic.Pillon <[email protected]>
If USB CDC is enabled then the generic "Serial" used will be SerialUSB else this is the HardwareSerial if one is defined. If Serial is defined before (build_opt.h, variant.h) then this is the one used. ISO for generic "serialEvent". Signed-off-by: Frederic.Pillon <[email protected]>
|
Does this affect the naming sequence of the other Serial instances? eg. will Serial3 become Serial 2 if Serial is remapped to USB? |
|
@BennehBoy, no
|
Rename "Serial interface" to "U(S)ART support" Rename "USB interface" to "USB support" Add "USB speed" menu for USB speed: LS/FS/HS/HS in FS Reword some descriptions Signed-off-by: Frederic Pillon <[email protected]>
|
I've updated/reword the menu to have better description and usage. This will allow ease to introduce further USB Class support (MSC, Midi,...) |
|
Looks good |
Signed-off-by: Frederic Pillon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to have
Serialmapped onSerialUSBif USB CDC is enabled.If USB CDC is enabled then the generic "
Serial" used will beSerialUSBelse this is the
HardwareSerialif one is defined.If
Serialis defined before (build_opt.h,variant.h)then this is the one used.
ISO for generic "
serialEvent".