-
Notifications
You must be signed in to change notification settings - Fork 1k
Add Armed v1 board variant #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think it should also be nice to not add a new section for this board and follow @hasenbanck recommendation in #361:
|
So # Armed boards
Armed.name=Armed Series would become # 3D printer boards
3dprinter.name=3D printer boards And then you would need to change Armed and RemRam into the new section "3dprinter". I would then rebase my changes again and we wouldn't clutter the the main section more then we need. |
Did you consider setting |
No, haven't thought about that. Will check it out!
Thanks.
…On Thu, Nov 1, 2018 at 8:21 AM Nils Hasenbanck ***@***.***> wrote:
Did you consider setting #define PWM_FREQUENCY 20000 // >= 20 Khz =>
inaudible noise for fans? I personally find low running FAN noise to be
highly disturbing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#364 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQ8NJHfr0IMNSTrk2ECf2iA-paiHkIYvks5uqqD_gaJpZM4YFfl6>
.
|
Would sharing a "3d printer" section require all boards in that section to use the save USB vid/pid? 3dprinter.build.vid=0x0483 |
USB will be part of 1.5 based on @hasenbanck |
Ok. @hasenbanck , do you want med to submit the PR regarding the rename or will you do it? |
@ktand I'm at work and would only have time this evening. If you are faster, then please do it yourself. |
Same here. |
Found some time in the break. Here we go: #365 |
Is there any way I can base my PR on your PR? Or do I have to wait for your PR to be merged before I can adjust mine? |
I would wait for the merge of the other PR and then do a rebase of this PR. |
#365 merged. |
I have updated my PR as suggested. |
Tweaked SPI pin definition. Ready to be merged. |
7d25e1b
to
ad65d9a
Compare
Signed-off-by: Frederic.Pillon <[email protected]>
Thanks @ktand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PeripheralPins.c is not the last version but this is not an issue if there is no ETH on this board
@fpistm There is no ethernet on this board, but I can update the file to the latest version if you like. |
@ktand No, if no ethernet that's good.
|
@fpistm Sorry for the delay, cleaned up project and pushed to Github. Here is the link: Armed on Github |
I approve the usage of good fuses! Nice board design! |
Add Armed v1 board variant
Armed is a 3D printer controller based on STM32F407 designed to run Marlin.