I2C Slave : rework slave receive data sequence #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work includes some rework of the Slave RX path, which is based on below principle: - we don't know in advance how many bytes will be sent by the I2C master so we'll be listening to bytes 1 by 1 - in order to get them one by one, we're programing the I2C with HAL_I2C_Slave_Sequential_Receive_IT and 1 byte at a time and we're using the HAL_I2C_SlaveRxCpltCallback to store the byte then programing again for next byte. - this sequence is ended when the HAL_I2C_ListenCpltCallback is called, which happens when the master ends the ongoing sequence. We can then prepare for the next one. In order to implement this mecanism, we're introduced a local counter slaveRxNbData where we store the number of received bytes, as well as a new slave mode SLAVE_MODE_LISTEN which allows for extra checks. i2c_s structure members that can be modified from main context or under interrupt context have been marked as volatile.
For STM32 families that have a DutyCycle init parameter, we need to select the Fast Mode dedicated configuration which will set the fast mode bit in CCR register.
Squonk42
approved these changes
Aug 20, 2018
There was a problem hiding this comment.
I tried an I2C communication between an Arduino Pro Mini 168 (3.3V) clone and an STM32F103C8T6 BluePill with the STM Core master branch plus PR #306, flashing the example "master_reader_writer" sketch on one side, and the "slave_sender_receiver" sketch on the other side:
-
if the BluePill is the master and the Pro Mini the slave, everything is still working OK
-
if the BluePill is the slave and the Pro Mini the master, everything is now working OK
Case 2 was not working previously:
http://www.stm32duino.com/viewtopic.php?t=3612#p45190
Thanks for the successful changes!
fpistm
requested changes
Sep 3, 2018
cores/arduino/stm32/twi.c
Outdated
| i2c_t *obj = get_i2c_obj(hi2c); | ||
|
|
||
| /* Previous master transaction now ended, so inform upper layer if needed | ||
| * then prepare for listeing to next request */ |
cores/arduino/stm32/twi.c
Outdated
| void HAL_I2C_SlaveTxCpltCallback(I2C_HandleTypeDef *hi2c) | ||
| { | ||
| i2c_t *obj = get_i2c_obj(hi2c); | ||
| /* reset transmit buffer size */ |
There was a problem hiding this comment.
Please, remove one space and use capital letter for first letter.
/* Reset
fpistm
approved these changes
Sep 4, 2018
benwaffle
pushed a commit
to benwaffle/Arduino_Core_STM32
that referenced
this pull request
Apr 10, 2019
I2C Slave : rework slave receive data sequence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work includes some rework of the Slave RX path, which is based on
below principle:
so we'll be listening to bytes 1 by 1
HAL_I2C_Slave_Sequential_Receive_IT and 1 byte at a time and we're using
the HAL_I2C_SlaveRxCpltCallback to store the byte then programing again
for next byte.
which happens when the master ends the ongoing sequence. We can then
prepare for the next one.
In order to implement this mecanism, we're introduced a local counter
slaveRxNbData where we store the number of received bytes, as well as a
new slave mode SLAVE_MODE_LISTEN which allows for extra checks.
i2c_s structure members that can be modified from main context or under
interrupt context have been marked as volatile.
Addresses #217
TESTS
Example used: master_reader_writer + slave_sender_recevier
Has been tested with NUCLEO boards F411RE, L152RE, F091RC, L476_RG in various combinations 1 as master, the other as slave, with a X-NUCLEO-IKS01A1 connected on one board to provide the required pull-up resistors on the I2C lines.