-
Notifications
You must be signed in to change notification settings - Fork 1k
Added STM32F030K6 as Generic type #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I saw that the checks have failed. What is the idea behind the onboard led? A generic Chips does not have on board LEDs. Since there is no board at all. |
Hi, thanks, You're right, Blink sketch it's probably not the best sketch to build for Travis. |
Thanks for your response. If you have some guidlines for further contributions, please let me know so that i can follow them in the future. By the way, i tried to open an account on the stm32duino forum. Unfortunately i never received an activation email. |
As some variant could not have LED_BUILTIN use the bare example. See #293 Signed-off-by: Frederic.Pillon <[email protected]>
Thank you for your review. |
I never seen on arduino core family a variant without a board. |
This can be discussed. |
@Testato the idea behind this is to support any board you imagine with this particular chip on it. |
Corrected pin-definition in variant.cpp and variant.h
I have changed all files according to your review requests. I only havent figured out how to implement the board.txt in such a way that we can shoose the specific chip in the "board part number" dropdown instead of the "board" drop down. |
verified with physical board. GPIOs, timers, serial interfaces are working! |
IIRC the ESP8266 Arduino core has a drop down menu for selecting the pin for the LED, don’t know if something similar is workable for STM32 (like defining a common subset of GPIO ports across families?) |
As some variant could not have LED_BUILTIN use the bare example. See stm32duino#293 Signed-off-by: Frederic.Pillon <[email protected]>
I wrote a sketch that displays the input of PA0. #include <Arduino.h> const int AnalogPin = PA0; void setup(void) { void loop(void) { |
Since this PR was submit, several update of the core has been added which would allow to be more generic. |
As some variant could not have LED_BUILTIN use the bare example. See stm32duino#293 Signed-off-by: Frederic.Pillon <[email protected]>
Hello
I have tried to add the STM32F030K6 as a generic part.
This config compiles successfully. I will add more Parts if this is appreciated.
Regards
Swissbyte