PR 177 review: Add RTC driver #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fpr <[email protected]>
Signed-off-by: fpr <[email protected]>
#if defined(STM32L100xBA) || defined (STM32L151xBA) || defined (STM32L152xBA) ||\
defined(STM32L100xC) || defined (STM32L151xC) || defined (STM32L152xC) ||\
defined (STM32L162xC) || defined(STM32L151xCA) || defined (STM32L151xD) ||\
defined (STM32L152xCA) || defined (STM32L152xD) || defined (STM32L162xCA) ||\
defined (STM32L162xD) || defined(STM32L151xE) || defined(STM32L151xDX) ||\
defined (STM32L152xE) || defined (STM32L152xDX) || defined (STM32L162xE) ||\
defined (STM32L162xDX)
#define STM32L1_ULPH
#endif
Signed-off-by: Frederic.Pillon <[email protected]>
day -> wday is a week day (1 to 7) date -> day is day (1 to 31). Mainly named "date" in HAL side format -> period is day period AM or PM. Mainly named "time format" in HAL side Signed-off-by: Frederic.Pillon <[email protected]>
Closed
LMESTM
approved these changes
Apr 25, 2018
cores/arduino/stm32/rtc.c
Outdated
| @@ -546,7 +546,7 @@ void RTC_GetDate(uint8_t *year, uint8_t *month, uint8_t *day, uint8_t *wday) | |||
| * @param period: AM or PM if in 12 hours mode else ignored. | |||
| * @retval None | |||
| */ | |||
| void RTC_StartAlarm(uint8_t day, uint8_t hours, uint8_t minutes, uint8_t seconds, uint32_t subSeconds, hourAM_PM_t period) | |||
| void RTC_StartAlarm(uint8_t day, uint8_t hours, uint8_t minutes, uint8_t seconds, uint32_t subSeconds, hourAM_PM_t period, uint8_t mask) | |||
There was a problem hiding this comment.
Please add the "mask" parameter description of the function - need to clarify how this is going to be used
Signed-off-by: Frederic.Pillon <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
RTC_SetClockSource() exported RTC_getPrediv() exported RTC_computePrediv() added Hardened code Signed-off-by: Frederic.Pillon <[email protected]>
Signed-off-by: Frederic.Pillon <[email protected]>
benwaffle
pushed a commit
to benwaffle/Arduino_Core_STM32
that referenced
this pull request
Apr 10, 2019
Add RTC driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review of #177
This fix and enhance the preview PR:
To do in a further update manage the second alarm: RTC_ALARM_B