Skip to content

fix(SubGhz): SPISettings not properly defined #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions libraries/SubGhz/src/SubGhz.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ extern "C" void SUBGHZ_Radio_IRQHandler(void)
SubGhz.handleIrq();
}

constexpr SPISettings SubGhzClass::spi_settings;

void SubGhzClass::handleIrq()
{
if (callback) {
Expand Down
2 changes: 1 addition & 1 deletion libraries/SubGhz/src/SubGhz.h
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ class SubGhzClass {
// supported by the radio, which should always work (no chance of
// bad wiring that requires reducing the speed).
// This value should be passed to `SubGhz.SPI.beginTransaction()`.
static constexpr SPISettings spi_settings = {16000000, MSBFIRST, SPI_MODE0};
const SPISettings spi_settings = {16000000, MSBFIRST, SPI_MODE0};

protected:
// To access handleIrq()
Expand Down