Add variant G070RB #1609
Closed
Add variant G070RB #1609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABOSTM
suggested changes
Jan 4, 2022
There was a problem hiding this comment.
Hi @MrZloHex,
Thanks for this PR.
Few inline comment.
Also could you run Astyle on generic_clock.c:
https://github.com/stm32duino/wiki/wiki/Astyle
|
By the way, you can squash the whole in a single commit. |
Co-authored-by: Alexandre Bourdiol <[email protected]>
Co-authored-by: Alexandre Bourdiol <[email protected]>
|
Thanks for the update, could you run Astyle on generic_clock.c: |
|
Ok |
|
Any update on this PR ? |
|
This PR is superseded by #1638 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Summary
Adding new variant for Generic
G070RBTThis PR fixes/implements the following bugs/features
New variant will be supported by stm32duino