Fix I2C bug for F4 platforms in IT mode #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMESTM
approved these changes
Nov 21, 2017
There was a problem hiding this comment.
I think the change will improve stability and robustness.
Neverthless I would also expect drivers (like eeprom drivers or NFC drivers) to call i2c_IsDeviceReady(à until the device is ready and before issuing the read or write requests. If the drivers behave like proposed, then the read or write operations would work without AF errors.
|
Unfortunately, it seems that the "i2c_IsDeviceReady" is only a low level API that is not available in the Wire library. So we cannot use that API for Arduino libraries. Anyway, the proposed patch should fix the I2C issue without any change in the Wire library. |
|
@cparata ok looks good to me ! |
fpistm
approved these changes
Nov 22, 2017
|
This Fix #153 |
benwaffle
pushed a commit
to benwaffle/Arduino_Core_STM32
that referenced
this pull request
Apr 10, 2019
Fix I2C bug for F4 platforms in IT mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
this patch should fix this bug. I successfully tested it with Nucleo-F401RE and X-NUCLEO-NFC01A1 and X-NUCLEO-NFC04A1. In order to fix it, I took inspiration by Cube HAL examples for I2C in IT mode. Please, let me know if it works also on your side.
Best Regards,
Carlo