config: add debug information menu #1446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Patch looks good to me. Maybe name it "Debug symbols" instead of "Debug information"? I can imagine the latter makes people expect that additional debug info will be printed? |
|
Thanks @matthijskooijman for your feedback. |
Fixes stm32duino#873 Signed-off-by: Frederic Pillon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a new menu
Debug information.By default it is not enabled. Enable it will produce debugging information.
It also fix the
Optimizemenu which displayedDebug (-g)instead of "Debug (-Og)".Fixes #873
For further reading: https://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html#Debugging-Options
/CC @matthijskooijman