Skip to content

Fix two assert_param calls. #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fix two assert_param calls. #1242

merged 1 commit into from
Dec 1, 2020

Conversation

ghent360
Copy link
Contributor

Running Marlin with USE_FULL_ASSERT defined as 1 revealed 2 asserts:

assert_param(IS_TIM_CC1_INSTANCE(htim->Instance));

while using TIM7 for TIMER_SERVO on STM32F407 - switched to TIM14

assert_param(IS_I2C_OWN_ADDRESS2(hi2c->Init.OwnAddress2));

default value was filled as 0xff from twi.c, changed to even value 0xfe.

@fpistm fpistm requested a review from ABOSTM November 29, 2020 09:50
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ghent360
Thanks for this pull request.
I have 2 remarks about your fix, see inline.

@fpistm fpistm added bug 🐛 Something isn't working fix 🩹 Bug fix labels Dec 1, 2020
@fpistm fpistm added this to the 2.0.0 milestone Dec 1, 2020
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm merged commit 5f95b95 into stm32duino:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working fix 🩹 Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants