Add requestFrom(uint8_t address, size_t quantity, bool sendStop) #1184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABOSTM
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
LGTM.
After discussion with @fpistm, we conclude that it is not worth today to implement the code in
:requestFrom(uint8_t address, size_t quantity, bool sendStop)
instead of
requestFrom((uint8_t)address, (uint8_t)quantity, (uint8_t)sendStop)
like others like megaavr. It won't change neither the API nor the behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing function declaration that aligns further with the arduino spec as specified in issue #1183
This is to fix compilation with an external Arduino library ArduinoECCX08
Fixes #1183