Skip to content

Update PlatformIO scripts #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2020
Merged

Update PlatformIO scripts #1164

merged 3 commits into from
Sep 4, 2020

Conversation

valeros
Copy link
Contributor

@valeros valeros commented Sep 3, 2020

This PR synchronizes the latest changes in the build script for PlatformIO.

@fpistm fpistm self-requested a review September 3, 2020 10:08
@fpistm fpistm added the enhancement New feature or request label Sep 3, 2020
@fpistm fpistm added this to the 2.0.0 milestone Sep 3, 2020
@fpistm fpistm mentioned this pull request Sep 3, 2020
Merged
@fpistm
Copy link
Member

fpistm commented Sep 3, 2020

Thanks @valeros

I've updated the workflow config to run GitHub action when this file is modified (#1165).

In the meantime, I've saw that PIO build is now failed since few hours and I don't understand why like nothing has changed in the core:
https://github.com/stm32duino/Arduino_Core_STM32/runs/1067702793?check_suite_focus=true

Tool Manager: Installing platformio/framework-arduinoststm32 @ *
Downloading...
Unpacking...
Error: Could not install package 'platformio/framework-arduinoststm32 @ *' for 'linux_x86_64' system

It seems the pio installer is different? Before there is no reference to the Tool Manager.

@valeros valeros changed the title Update PlatformIO build script Update PlatformIO scripts Sep 3, 2020
@valeros
Copy link
Contributor Author

valeros commented Sep 3, 2020

@fpistm Thanks, I also updated the CI script.

fpistm
fpistm approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PIO CI OK.
LGTM
Thanks @valeros

@fpistm fpistm merged commit 6b6a254 into stm32duino:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@valeros @fpistm