initialize state before calling HAL_XXX_Init for SPI and I2C #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
reviewed
Sep 26, 2017
cores/arduino/stm32/spi_com.c
Outdated
| @@ -371,6 +371,8 @@ void spi_init(spi_t *obj, uint32_t speed, spi_mode_e mode, uint8_t msb) | |||
| } | |||
| #endif | |||
|
|
|||
| handle->State = HAL_SPI_STATE_RESET; | |||
There was a problem hiding this comment.
Could you move this line in the /* Fill default value */ (start at line number 222)
If we use a dynamic instanciation, the state is not well initialized. This can ends with a blocking or strange behaviour. This issue is mainly met when doing soft reset (button).
VVESTM
force-pushed
the
hal_state_reset
branch
from
7bcc843 to
3e44d53
Compare
|
New version following @fpistm remarks |
fpistm
approved these changes
Sep 26, 2017
ghost
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use a dynamic instanciation, the state is not well
initialized. This can ends with a blocking or strange
behaviour.