Add missing timer IRQHandler and fix wrong timer IRQHandler #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
fpistm
reviewed
Sep 25, 2017
cores/arduino/stm32/timer.c
Outdated
| * @param None | ||
| * @retval None | ||
| */ | ||
| #if defined(STM32F0xx) |
There was a problem hiding this comment.
Why not use TIM1_IRQHandler and define the proper one like the other (#define TIM1_IRQHandler TIM1_BRK_UP_TRG_COM_IRQHandler ...) in timer.h
in order to be homogeneous?
There was a problem hiding this comment.
I tried but when timer 10 or 16 are present, there is an error about redefinition:
'error: redefinition of 'TIM1_UP_TIM16_IRQHandler'
There was a problem hiding this comment.
On which MCU ?
however, for TIM10 handler, it seems strange for STM32F1xx
+#elif defined(STM32F2xx) || defined(STM32F4xx) || defined(STM32F7xx)
void TIM1_UP_TIM10_IRQHandler(void)
but
+#if defined(STM32F1xx) || defined(STM32F2xx) || defined(STM32F4xx) || defined(STM32F7xx)
if(timer_handles[9] != NULL) {
HAL_TIM_IRQHandler(timer_handles[9]);
| { | ||
| if(timer_handles[0] != NULL) { | ||
| HAL_TIM_IRQHandler(timer_handles[0]); | ||
| } | ||
|
|
||
| #if defined(STM32F1xx) || defined(STM32F2xx) || defined(STM32F4xx) || defined(STM32F7xx) |
There was a problem hiding this comment.
So this one could be removed as handle by TIM10_IRQHandler
cores/arduino/stm32/timer.c
Outdated
| if(timer_handles[9] != NULL) { | ||
| HAL_TIM_IRQHandler(timer_handles[9]); | ||
| } | ||
| #endif | ||
|
|
||
| #if defined(STM32F1xx) || defined(STM32F3xx) || defined(STM32L4xx) |
There was a problem hiding this comment.
So this one could be removed as handle by TIM16_IRQHandler
Signed-off-by: fpr <[email protected]>
fpistm
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #111