Skip to content

[SoftwareSerial] Fix analog pins usage #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2020
Merged

[SoftwareSerial] Fix analog pins usage #1094

merged 1 commit into from
Jun 10, 2020

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jun 10, 2020 •
edited
Loading

Fix #1093

@chrissbarr could you test, please?

@fpistm fpistm added bug 🐛 Something isn't working fix 🩹 Bug fix labels Jun 10, 2020
@fpistm fpistm added this to the 2.0.0 milestone Jun 10, 2020
@fpistm fpistm requested a review from ABOSTM June 10, 2020 09:57
@chrissbarr
Copy link
Contributor

That was quick @fpistm!

Yes, this is working for me for all of the scenarios I described in #1093. No freezing anymore, plus I can confirm that I'm seeing the serial output on those pins.

@fpistm
Copy link
Member Author

fpistm commented Jun 10, 2020

Issue was simple. So quick to solve. 😉

@fpistm
Copy link
Member Author

fpistm commented Jun 10, 2020

I will wait @ABOSTM as he deployed the SoftwareSerial library 😄

@fpistm fpistm merged commit 9876616 into stm32duino:master Jun 10, 2020
@fpistm fpistm deleted the swserial branch June 10, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABOSTM ABOSTM ABOSTM approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something isn't working fix 🩹 Bug fix
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

SoftwareSerial Freezes on Certain Pins (Analog?)
3 participants
@fpistm @chrissbarr @ABOSTM