Remove Ethernet library dependency #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
LMESTM
reviewed
Sep 12, 2017
cores/arduino/chip.h
Outdated
| @@ -37,8 +37,7 @@ | |||
| #ifdef USBCON | |||
| #include "usb_interface.h" | |||
| #endif //USBCON | |||
|
|
|||
| #include "ethernet.h" | |||
| #include "callback.h" | |||
There was a problem hiding this comment.
Maybe use variant name to be more precise
Update after discussion with Fred, we think a suitable name could be
coreCallback.h
with
registerCoreCallback( xx )
unregisterCoreCallback( xx )
and the call from the core will be
coreCallbacks();
?
|
I attach the stm32_eth_scheduler() inside the STM32Ethernet library. See here |
|
Wait renaming and rebasing. |
fpistm
approved these changes
Sep 12, 2017
fpistm
reviewed
Sep 14, 2017
cores/arduino/stm32/core_callback.h
Outdated
| */ | ||
| } | ||
| #ifndef CALLBACK_LIST_SIZE | ||
| #define CALLBACK_LIST_SIZE 8 |
There was a problem hiding this comment.
Please decrease to 4 it should be enough then I will merge
…rary Signed-off-by: fpr <[email protected]>
fpistm
approved these changes
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ethernet library is no more linked to the core.
See STM32Ethernet PR.