Skip to content

[New Variant] Nucleo L452RE-P Support #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jgromes opened this issue Sep 26, 2019 · 3 comments · Fixed by #673
Closed

[New Variant] Nucleo L452RE-P Support #671

jgromes opened this issue Sep 26, 2019 · 3 comments · Fixed by #673
Labels
new variant Add support of new bard

Comments

@jgromes
Copy link
Contributor

jgromes commented Sep 26, 2019

Hi, I'd like to add support for Nucleo L452RE-P. There's already a variant for L452RE, and it looks like code compiled for L452RE does upload to L452RE-P. Since the LED in the Blink example doesn't blink, I guess there's some difference in pin mapping.

Is it enough to add a few #ifdef statements to the variant files (like with L496ZG and L496ZG-P), and the new variant into boards.txt, or is there something else as well? Thanks!

@jgromes jgromes added the new variant Add support of new bard label Sep 26, 2019
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Sep 27, 2019
Fixes stm32duino#671

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm
Copy link
Member

fpistm commented Sep 27, 2019

Hi @jgromes
looking at your point, I saw some minor issue so I've updated it and add the -P variant.
I've tested Blink, I2C, Serial, SPI and Analog.

@fpistm fpistm added this to the 1.8.0 milestone Sep 27, 2019
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Sep 27, 2019
Fixes stm32duino#671

Signed-off-by: Frederic Pillon <[email protected]>
@jgromes
Copy link
Contributor Author

jgromes commented Sep 27, 2019

Wow, that was fast - I can confirm it's working, will let you know if any issues pop up.

Thanks!

@jgromes jgromes closed this as completed Sep 27, 2019
@fpistm
Copy link
Member

fpistm commented Sep 27, 2019

Welcome do not hesitate to open other issue if you meet one.

fpistm added a commit that referenced this issue Sep 27, 2019
Fixes #671

Signed-off-by: Frederic Pillon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants