Skip to content

analog.c can't deal with a chip that doesn't have a DAC #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RickKimball opened this issue Jun 12, 2017 · 2 comments
Closed

analog.c can't deal with a chip that doesn't have a DAC #26

RickKimball opened this issue Jun 12, 2017 · 2 comments
Assignees
@RickKimball @fpistm
Labels
bug 🐛 Something isn't working

Comments

@RickKimball
Copy link
Contributor

I'm trying to add a variant for the STM32F030R8, however it doesn't have a DAC. The analog.c file fails to compile because of all the DAC structures and defines used.

My solution was a complete hack, I just ifdefed out code that wouldn't compile.

It seems that to grow into a broader range of chips and boards this is going to have to be addressed.
@fpistm fpistm self-assigned this Jun 12, 2017
@fpistm fpistm added the bug 🐛 Something isn't working label Jun 12, 2017
fpistm added a commit that referenced this issue Jun 12, 2017
@fpistm
Fix when HAL_DAC_MODULE_ENABLED is not defined
a7a7e60 
Fix #26

Signed-off-by: Frederic Pillon <[email protected]>
@RickKimball
Copy link
Contributor Author

RickKimball commented Jun 13, 2017 •
edited
Loading

I cloned the Nucleo_F030R8 branch and tried this. It seems to be solved. Should I close this or wait for it to be merged into the master branch?

@fpistm
Copy link
Member

fpistm commented Jun 13, 2017

Thanks @RickKimball

@fpistm fpistm closed this as completed in 1003930 Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RickKimball RickKimball

@fpistm fpistm

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RickKimball @fpistm