Skip to content

IPAddress is missing the toString function interface？ #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
VirensCn opened this issue Mar 15, 2024 · 1 comment · Fixed by #2306
Closed

IPAddress is missing the toString function interface？ #2303

VirensCn opened this issue Mar 15, 2024 · 1 comment · Fixed by #2306
Labels
arduino compatibility enhancement New feature or request

Comments

@VirensCn
Copy link
Contributor

Arduino_Core_STM32/cores/arduino/IPAddress.h

Line 84 in 641f3d8

virtual size_t printTo(Print &p) const;

IPAddress is missing the toString function interface
@fpistm
Copy link
Member

fpistm commented Mar 15, 2024

Hi @VirensCn
Right, not existing when we've introduced this class 7 years ago. 😉
Looking at last implementation even ipv4/ipv6 not added.

Feel free to submit a PR.

@fpistm fpistm added enhancement New feature or request arduino compatibility labels Mar 15, 2024
This was referenced Mar 16, 2024
Closed
Merged
@fpistm fpistm linked a pull request Mar 18, 2024 that will close this issue
add "toString" function with IPAddress #2306
Merged
1 task
fpistm added a commit to VirensCn/Arduino_Core_STM32 that referenced this issue Mar 18, 2024
@fpistm
chore: update IPAdress class vs Arduino Core API
ea43b1e 
Fixes stm32duino#2303

Signed-off-by: Virens <[email protected]>
Co-Authored-By: Frederic Pillon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arduino compatibility enhancement New feature or request
Projects
STM32 core based on ST HAL
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add "toString" function with IPAddress VirensCn/Arduino_Core_STM32
2 participants
@VirensCn @fpistm