Skip to content

use empty(port) instead of !port to check for empty string #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

MotherOfUnicorns
Copy link
Contributor

I was getting this error message Error! No serial port found even when a port exists, seems the issue is with how it's checking for empty string.

@stevearc
Copy link
Owner

LGTM, thanks!

@stevearc stevearc merged commit 1a2859f into stevearc:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants