feat: add test to reproduce #605 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenkilbourn
commented
Nov 15, 2022
| act(() => { | ||
| ReactDOM.hydrate(testHarness(renderProps), container) | ||
| ReactDOM.hydrate(testHarness(renderProps), container || null) |
There was a problem hiding this comment.
✍🏼 If container is undefined, then we pass null to hydrate because undefined is not a valid container, but null is
| act(() => { | ||
| ReactDOM.unmountComponentAtNode(container) | ||
| if (typeof container !== 'undefined') { |
There was a problem hiding this comment.
✍🏼 Because act returns a function, it introduces a new scope which means we need to check again that container is not undefined before using it. This means we could remove the outer if (container) { check if we're okay that unmount always returns act}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This fixes a bug that assumes that tests don't run in SSR environments.
Why:
With frameworks like Next.js and Remix rendering components on the server, it's important that this library can mimic SSR environments as closely as possible.
How:
First by adding a test that reproduces the issue and then by moving this logic "into the hydrate function, so we reference document when they want it to render for real." (suggested by mpeyper).
Checklist: