Fix building with standalone sqlite3 >= 3.30.0 #970
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLite 3.30.0 changed the definition of SQLITE_DETERMINISTIC: `-#define SQLITE_DETERMINISTIC 0x800` `+#define SQLITE_DETERMINISTIC 0x000000800` Meaning that the (older) system sqlite3 library and the pod have different definitions, even though they're the same value. We've been importing the system sqlite3 module in SQLiteObjc.h even when linking against standalone sqlite. I added a check to SQLiteObjc.h to import the sqlite3 pod when we're using it, instead of always importing the system module. This leads to there being only one definition in scope.
|
Running into the same issue. Thank you for the solution! |
|
Thanks, I've just run into this as well. |
pull bot
pushed a commit
to FreddyZeng/SQLite.swift
that referenced
this pull request
Jan 19, 2020
Fix building with standalone sqlite3 >= 3.30.0
This was referenced Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using
SQLite.swift/standalonewithsqlite3pod version >= 3.30.0, attempting to build the project results in "ambiguous use" warning in Xcode pointing here.Solution
SQLite 3.30.0 changed the definition of SQLITE_DETERMINISTIC:
Meaning that the (older) system sqlite3 library and the pod have different definitions, even though they're the same value.
We've been importing the system SQLite3 module in
SQLiteObjc.heven when linking against standalone sqlite.I added a check to
SQLiteObjc.hto import the sqlite3 pod when we're using it, instead of always importing the system module.This leads to there being only one definition in scope.