Skip to content

add primary key with 4 columns #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2019
Merged

add primary key with 4 columns #853

merged 3 commits into from
Apr 27, 2019

Conversation

hellohuanlin
Copy link
Contributor

@hellohuanlin hellohuanlin commented Oct 16, 2018

Hi, I need to support 4 columns as the compound key. I am not able to create an extension because definitions variable primaryKey helper function are both fileprivate.

My current temp solution is to write the raw query, but i think it's better to update the library.

4 should be enough for most of projects.

related issue: #652

@hellohuanlin
Copy link
Contributor Author

cc @jberkel really appreciate your maintenance work on this library :). Any chance you could take a look 🙏?

@ypopovych
Copy link
Collaborator

Hello @hellohuanlin. Can you rebase it to the latest master? I think this is good PR to merge

@ypopovych ypopovych merged commit 5be9fa9 into stephencelis:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants