Skip to content

Please disable code coverage #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
IceyTH opened this issue Oct 9, 2017 · 3 comments
Closed

Please disable code coverage #742

IceyTH opened this issue Oct 9, 2017 · 3 comments

Comments

@IceyTH
Copy link

IceyTH commented Oct 9, 2017

Please disable code coverage to support Xcode9 with Carthage.

'codeCoverageEnabled' to "NO" in "SQLite iOS.xcscheme".

Thanks
IceyTH
@crudolf
Copy link

crudolf commented Oct 9, 2017 •
edited
Loading

This deactivation is required otherwise apple rejects submissions with activated codeCoverageEnabled:

Invalid Bundle - Disallowed LLVM instrumentation. Do not submit apps with LLVM profiling instrumentation or coverage collection enabled. Turn off LLVM profiling or code coverage, rebuild your app and resubmit the app.

We use sqlite using carthage.

jberkel added a commit that referenced this issue Oct 9, 2017
@jberkel
See #742
35bb87c
@jberkel jberkel mentioned this issue Oct 9, 2017
Merged
@jberkel
Copy link
Collaborator

jberkel commented Oct 9, 2017

Weird, that's a setting of the test action. Why does this affect the release build?

@jberkel
Copy link
Collaborator

jberkel commented Oct 13, 2017

Anyway, I've just removed the option since it's not needed. closing.

@jberkel jberkel closed this as completed Oct 13, 2017
ghost pushed a commit to readium/r2-lcp-swift that referenced this issue Oct 18, 2017
@iosDevEdrlab
Modified cartfile for pulling from master in order to avoid stephence…
1f151e4 
…lis/SQLite.swift#742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jberkel @crudolf @IceyTH