Skip to content

Enable TypeScript typings #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2019
Merged

Conversation

r3nya
Copy link
Contributor

@r3nya r3nya commented Jun 9, 2018

Description

Thanks for your project!
I noticed that stacktrace.js has typings for TypeScript but unfortunately doesn't enable it (https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#including-declarations-in-your-npm-package).

Motivation and Context

#204

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • node_modules/.bin/jscs -c .jscsrc stacktrace.js passes without errors
  • npm test passes without errors
  • I have read the contribution guidelines
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

@capaj
Copy link

capaj commented Jan 8, 2019

@eriwen why hasn't this been merged yet? This is a no-brainer.

@eriwen
Copy link
Member

eriwen commented Sep 14, 2019

Yep. Thank you for the contribution @r3nya!

@eriwen eriwen merged commit fba7522 into stacktracejs:master Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants